IE has serious trouble dealing with display: inline; on elements which don't have newlines between them. More detail here: http://drupal.org/node/199861

So this patch adds them, also makes the markup a bit more readable.

CommentFileSizeAuthor
#1 item-list-linebreak.patch2.24 KBdvessel
item-list-newline.patch674 bytescatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dvessel’s picture

dvessel CreditAttribution: dvessel commented
FileSize
item-list-linebreak.patch2.24 KB

The line break is missing in a few places. The problem is noticeable in the theme config page where the secondary tabs push into the right sidebar.

The issue is not isolated with IE. Seems to happen in all browsers and it's by design I think. Line breaks only happen when there's a space or any other character. Ends up treating the whole list like a single string with nothing in-between.

Also removes a stray li close tag for blog pages found when looking into this issue so it's included.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

dvessel: that's quite possible, I ran into this combined with IE not supporting :after - which would insert some whitespace, so it could be all browsers yeah. Thanks for looking into this in more depth, will take a proper look tomorrow.

dvessel’s picture

dvessel CreditAttribution: dvessel commented

This is also affecting rtl list items by preventing it from swapping the positioning.

http://drupal.org/node/203260

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Subscribe

druvision’s picture

druvision CreditAttribution: druvision commented

Verified - patching Drupal 6.0 RC2 solved the RTL issue.

Amnon
-
Professional: Drupal Israel | Drupal Development & Consulting | Eco-Healing | Effective Hosting Strategies | בניית אתרים
Personal: Hitech Dolphin: Regain Simple Joy :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed

Looks good, thanks Amnon for validating. Committed.

dvessel’s picture

dvessel CreditAttribution: dvessel commented

Gábor, there were other issues with RTL. Although this patch fixes wrapping problems, rtl gets a lot stranger.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.