It's a simple wrapper around a service. Use the service instead.

CommentFileSizeAuthor
#15 deprecate-file-usage-2104229-15.patch20.42 KBclaudiu.cristea
#11 deprecate-file-usage-2104229-11.patch20.38 KBclaudiu.cristea
#10 interdiff.txt670 bytesclaudiu.cristea
#10 deprecate-file-usage-2104229-10.patch21.93 KBclaudiu.cristea
#4 deprecate-file-usage-2104229-4.patch21.81 KBclaudiu.cristea
#2 deprecate-file-usage-2104229-1.patch24.92 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
Priority: Normal » Minor
Status: Active » Needs review
Issue tags: +API clean-up

Patch.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
FileSize
deprecate-file-usage-2104229-1.patch24.92 KB

Ah, missed the patch :)

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
Status: Needs review » Postponed

Postponing this to be sure that I don't have to rework this if it goes in before #2073033: Optimize file usage updates in file/image fields.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
Status: Postponed » Needs review
FileSize
deprecate-file-usage-2104229-4.patch21.81 KB

#2073033: Optimize file usage updates in file/image fields is in.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented

Reviewers? :)

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented

#4: deprecate-file-usage-2104229-4.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

We do know use \Drupal:: in tests, but I don't think this is important if we don't have a dedicated method on the Drupal class for file usage.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

Thank you. I have verified and no usage left of file_usage() other then function definition. Patch is green so RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work 
+++ b/core/includes/file.inc
@@ -916,7 +916,6 @@ function file_create_filename($basename, $directory) {
- * @see file_usage()->listUsage()

@@ -933,7 +932,6 @@ function file_delete($fid) {
- * @see file_usage()->listUsage()

Do we really want to remove the @see. These seem helpful to me. I would change these to @see \Drupal\file\FileUsage\FileUsageBase::delete()

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
Status: Needs work » Needs review
FileSize
deprecate-file-usage-2104229-10.patch21.93 KB
interdiff.txt670 bytes

Oh! OK, then.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
FileSize
deprecate-file-usage-2104229-11.patch20.38 KB

Rerolled after #2134951: Remove upgrade path tests.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Fixed » Needs work

Sorry, this conflicted with #2131851: Form errors must be specific to a form and not a global which was a critical issue so I ended up reverting this so that one could make it in. So this will need a small re-roll.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
Status: Needs work » Needs review
FileSize
deprecate-file-usage-2104229-15.patch20.42 KB

Rerolled.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Ok, re-committed to 8.x. :) Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.