Clean up Views relationship plugins [#2099343]

Comment	File	Size	Author
#3	2099343-2.patch	5.82 KB	damiankloip

#3	interdiff-2099343-2.txt	721 bytes	damiankloip
	vdc.clean-relationship-plugins.patch	5.82 KB	damiankloip

Comment #1

dawehner

German

CreditAttribution: dawehner commented 27 September 2013 at 14:28

Status:

Needs review

» Reviewed & tested by the community

Looks pretty decent!

Log in or register to post comments

Comment #2

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 2 October 2013 at 21:47

Status:

Reviewed & tested by the community

» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/Broken.php
@@ -25,9 +26,26 @@ public function adminLabel($short = FALSE) {
+  /**
+   * {@inheritdoc}
+   */
+  public function defineOptions() {
+    return array();
+  }

Should this not be protected like the implementation it is overriding in RelationshipPluginBase

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/Broken.php
@@ -25,9 +26,26 @@ public function adminLabel($short = FALSE) {
+  public function query() {
+  // No query to run.
+  }

Wrong indentation.