I'm currently using google_analytics-7.x-2.x and I came across your module. I was wondering if you are currently working on an updates to handle the new Google Universal Analytics? I have briefly looked through the changes: https://developers.google.com/analytics/devguides/collection/analyticsjs... and https://developers.google.com/analytics/devguides/collection/gajs/eventT... and I thought I might create a patch that would handle both or maybe just roll it into a 2.x for google_analytics_et. Just wanted your thoughts on the direction and to not duplicate efforts that may be going on. Let me know your thoughts.

Thanks - Scott

CommentFileSizeAuthor
#3 google_analytics_et-handle-universal-analytics-2098993-3.patch1.34 KBjonhines

Issue fork google_analytics_et-2098993

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

frob’s picture

frob
Primary language English
commented

That shouldn't warrant a 2.0 because the api should remain the same. Go ahead and roll the patch. I am in the middle of a couple other projects at the moment, but I would like to see what you have in mind.

frob’s picture

frob
Primary language English
commented

After reading some of the features for Universal Analytics This will definitely be in the scope coming up.

At first it will not require a 2.0 branch but it will spearhead the features I have in mind for 2.0

jonhines’s picture

jonhines commented
Issue summary: View changes
StatusFileSize
new google_analytics_et-handle-universal-analytics-2098993-3.patch1.34 KB

google_analytics-7.x-2.0 was released a week ago and I was looking at upgrading to it but thought it might break my events stuff. Here is a patch that I believe will do the trick to support universal analytics without breaking existing functionality.

jonhines’s picture

jonhines commented
Status: Active » Needs review
frob’s picture

frob
Primary language English
commented

That looks good. I will have to review with a universal code before I commit.

kurtismccartney’s picture

kurtismccartney commented

Did the update to the main GA module.
After having all of the jQuery quit working on the frontend this module was the source.

Thanks. Works great again with the patch.

sk33lz’s picture

sk33lz commented

Patch in #3 is tested with Google Analytics 2.x module. Initially ran into the same issue with JS not loading properly today after updating google_analytics and found this issue.

Looks ready for commit.

  • frob committed 6da6f57 on 7.x-1.x authored by jonhines 
    Issue #2098993 by jonhines | scottalan: Added Update to handle Universal...
frob’s picture

frob
Primary language English
commented
Status: Needs review » Fixed

I have commit this to dev and pushed up a new release.

hass’s picture

hass commented

Please note that there will be a D6 version with analytics.js next week.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Anonymous’s picture

Anonymous (not verified) commented

OfficiallyM made their first commit to this issue’s fork.