Provide config schema for View modes [#2096373]

This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced some config schema coverage for views, but it is not complete. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Figure out the missing pieces that are not yet covered. Write schema file sections for them. Clean up / fix any issues in current schema.

Create a configuration schema for entity type view_mode.

Comment	File	Size	Author
#3	schema_view_mode_entity-2096373-3.patch	1.26 KB	sushantpaste
#3
#1	schema_view_mode_entity-2096373-2.patch	1 KB	jsbalsera
#1
#1	entity_view_mode_raw_data.png	10.26 KB	jsbalsera
#1	entity_view_mode_config_inspector_form.png	26.57 KB	jsbalsera

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jsbalsera

he/his

Spanish

Córdoba, Spain

CreditAttribution: jsbalsera commented 28 September 2013 at 20:20

Status:

Active

» Needs review

File	Size
entity_view_mode_config_inspector_form.png	26.57 KB
entity_view_mode_raw_data.png	10.26 KB
schema_view_mode_entity-2096373-2.patch	1 KB

Raw data:

Config editor form:

Comment #2

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 13 October 2013 at 15:38

+++ b/core/modules/entity/config/schema/entity.schema.yml
@@ -0,0 +1,27 @@
+# Configuration schema for entity type entity_display
...
+      label: 'Entity type this form or view mode is used for'
...
+      label: 'Whether or not this form or view mode has custom settings by default'
...
+      label: 'Whether or not the rendered output of this view mode is cached by default'

May need some update on comments and labels?

Comment #3

sushantpaste

Marathi

Sawantwadi India

CreditAttribution: sushantpaste commented 10 November 2013 at 07:41

Assigned:	Unassigned	» sushantpaste
Issue summary:	View changes

File	Size
schema_view_mode_entity-2096373-3.patch	1.26 KB

Updated patch with label changes.

Comment #4

Sumeet.Pareek CreditAttribution: Sumeet.Pareek commented 10 November 2013 at 07:44

I am trying to manually review this during a contib mentoring sprint at - 2013.drupalcampdelhi.com

When I apply the patch I do get the entity.schema.yml file created in the right place, but then the manual testing steps noted here talk about comparing this file to the corresponding data.yml file, which I am not able to locate :-(

Oh btw, this is my day 1 with D8, so I am sure I would sound silly. But I have decided not to let go without manually reviewing this issue/patch like it should be *looks deteremined*

Comment #5

gaurav.goyal CreditAttribution: gaurav.goyal commented 10 November 2013 at 09:32

Hey this was my first manual patch Review and was pretty much exciting,
the patch reviews are as follows : -

Applied the patch using git apply and patch got applied successfully.
Checked the configuration file and schema file and using (https://drupal.org/project/config_inspector), and is working correctly