Updated: Comment #0

Problem/Motivation

\Drupal\search\Form\SearchSettingsForm contains a "use" statement for \Drupal\Core\Extension\ModuleHandler but that class is not used. Because it is (incorrectly) type-hinted as a member variable PhpStorm does not report it as unused.

Proposed resolution

Fix the type-hint and remove the "use" statement.

Remaining tasks

Review & commit the patch.

CommentFileSizeAuthor
#1 search-settings-form-unused-module-handler.patch974 byteststoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Active » Needs review
FileSize
search-settings-form-unused-module-handler.patch974 bytes

Here we go.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch, thanks!

Committed and pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.