Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem
Quick edit option appears twice on contextual links menu (see attachment).
Steps to reproduce
- Create and publish Basic page using Full HTML content type
- Click on contextual edit link
Comment | File | Size | Author |
---|---|---|---|
#8 | 2089397-8.patch | 1.31 KB | Wim Leers |
#8 | interdiff.txt | 1.27 KB | Wim Leers |
#7 | 2089397-7.patch | 1.24 KB | swentel |
Zrzut ekranu z 2013-09-15 11:58:50.png | 119.3 KB | mwysinski |
Comments
Comment #1
webchickHuh. Well that is silly.
Comment #2
Wim LeersReproduced! The bizarre thing is that this *only* happens to "basic page" nodes, not to "article" nodes. It's reliably reproducable, not just after having created a "basic page" node, but also when reloading it. It only happens on the full node page, not on the frontpage where the teaser view mode of the node is displayed.
Similar symptoms to #2014893: Multiple "quick edit" links inserted into the contextual links when an field is edited and saved., but completely different steps to reproduce.
Much thanks for reporting!
Comment #3
sidharthapReproduced! This only happens to "basic page" nodes.
Comment #4
joachim CreditAttribution: joachim commentedThis happens to article nodes too when viewed on a full page.
Comment #5
Wim Leers#3: indeed.
#4: I cant reproduce that.
Comment #6
swentel CreditAttribution: swentel commentedJesse's patch on the other issue (#12) fixes this - https://drupal.org/node/2014893#comment-7683153
Comment #7
swentel CreditAttribution: swentel commentedMoving over that patch here.
Comment #8
Wim LeersThanks, swentel, you beat me to it :)
I tested this thoroughly manually, in many scenarios, and it definitely solves the problem.
Committer, please give commit credit to
jessebeach
as well, she's the one who actually rolled the patch in #7!Tiny reroll, just to fix docs nitpicks.
P.S.: This will conflict with #1993894: Contextual quick edit toggle should be a <a role="button"> not a <a> because it tracks on/off state.
Comment #9
webchickWow, great sluething!!
Committed and pushed to 8.x. Thanks!
Comment #10
Wim LeersThanks! :)