Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Updated: Comment #0
Problem/Motivation
We have IntegerItem (id integer_field) to wrap the integer data type, but no FloatItem to wrap the float data type
Proposed resolution
Add one
Remaining tasks
Review
User interface changes
None
API changes
None
Related Issues
None
Comment | File | Size | Author |
---|---|---|---|
#1 | float-item.patch | 2.34 KB | larowlan |
Comments
Comment #1
larowlanComment #2
jibranWhy s this task and not a feature request?
Why are we replacing these lines? Should we not be adding new test?
Comment #3
larowlan@jibran
I classed it as a task because its an oversight that its missing, and I filed it in response to a direct question about why didn't we have one from someone porting a module to D8.
I changed the tests because they are verifying validation works for typed data, only integer_field is tested yet there are numerous others. I figured so long as we keep testing validation (which we are) but we use an alternate type (float) then we get the best of both worlds - we continue testing validation, but we also get float field testing. There are other remaining validation tests that test integer field
Comment #4
jibranI have no further questions.
Comment #5
alexpottCommitted bd5e049 and pushed to 8.x. Thanks!
Comment #7
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedCross-posting: #2542760: Move Float fields to contrib