While the color module generally does a great job creating beautiful color schemes on the fly, it shouldn't mess around with message color. It's not without a reason that an error message is red, a warning yellow and a status message green.

I picked out some of the preconfigured color schemes on Garland, which produced the most confusing messages:

  • In "Belgian Chocolate", status messages are correctly displayed in green, but bordered in yellow. This blurs the distinction between status message and warning. The error message is okay.
  • In "Cold Day", status messages are okay. Here the problem arises with error messages which are brownish on a light orange background with a red border. Apart from three colors being overly complex, this looks more like a warning than an error message.
  • Worst case is "Shiny Tomato", where status messages are blue instead of green, and error messages are green (!!!) on a light green background and with a red border. Here, warnings look more like an error message than errors themselves.

Although I'm not sure whether this is new, it is definitely unacceptable and must be fixed before final release. It is not just about appearance, but a serious usability bug. If I'm being too bold setting this to critical, please correct me.

Note, that the colors for warnings seem to be fixed as well as the border of error messages. IMHO colors for the three types of messages should be generally fixed. Some opinions would be great.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pancho’s picture

FileSize
10.5 KB

Of course this also applies to the "password strength meter". The green warning is really confusing and hardly readable.

webchick’s picture

Priority: Critical » Normal

While I recognize that this could be confusing for people, it doesn't qualify as a critical bug.

Gábor Hojtsy’s picture

BTW color module replaces colors when they are the same as defined in the color specks. So it might be a side effect, but it is more likely that it is a bug somewhere in the recoloring code. Check to see if you can reproduce with Drupal 5 first please, so we know if we should look at changes or the code at large.

Matt V.’s picture

The issue does not appear in Drupal 5. I'm attaching comparable screenshots I took in Drupal version 5.2. I hope that helps.

dvessel’s picture

Status: Active » Needs review
FileSize
648 bytes

This happened with the color patches. The strpos() check had the parameters fliped. Not my doing. :p

[edit: actually it was.. heh.]

Pancho’s picture

Works as advertised, and it's been sooo easy... :) Please rtbc.

Gábor Hojtsy’s picture

Status: Needs review » Fixed

OK, this looks trivial, strpos() uses haystack first and needle second (you search the needle in the haystack :). Committed, thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.