The links to the report of available updates and the settings page are broken. The patch points them to the new, correct, path.

To reproduce:

  • On the main navigation, select Administer--Help
  • Under Help topics, select Update status
  • Select either of the links in the 2nd paragraph

Results: Get a page not found error

Expected: Either see the update report, or the update module settings page.

CommentFileSizeAuthor
#3 broken-update-module-help-links_1.patch2.06 KBdww
#1 broken-update-module-help-links.patch1.89 KBScoutBaker
broken-update-module-help-links.patch1.9 KBScoutBaker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ScoutBaker’s picture

ScoutBaker CreditAttribution: ScoutBaker commented
FileSize
broken-update-module-help-links.patch1.89 KB

Correct patch file with fixed linefeeds.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Needs review » Reviewed & tested by the community

Good catch. Wow, that's funny... I'm the one who renamed those paths (http://drupal.org/node/165140), and update.module is the part of core I maintain. You'd think I would have gotten this right. ;)

Anyway, applies cleanly and works as advertised. Definitely RTBC.

Thanks!
-Derek

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
FileSize
broken-update-module-help-links_1.patch2.06 KB

Here's a re-roll from the webroot, where we prefer to have core patches rolled to make it easier for the core maintainers to apply and commit them... Otherwise, identical patch, so still RTBC.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

ScoutBaker’s picture

ScoutBaker CreditAttribution: ScoutBaker commented

@dww - Thanks for the re-roll. I actually did run my patch from webroot, but I see that my client didn't use the -p switch. I'll see about fixing that for the next time I submit something.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented

@ScoutBaker. Right, you also left off the -p. ;) But, observe:

http://drupal.org/files/issues/broken-update-module-help-links_0.patch

--- update.module	8 Jan 2008 10:35:43 -0000	1.8
+++ update.module	9 Jan 2008 08:17:37 -0000

that means "patch the file called 'update.module'" -- no directories, nothing. therefore, you have to "cd modules/update; patch < ../../foo" to apply the patch, or manually type in the path once patch complains it can't find the "update.module" in the root dir.

vs.
http://drupal.org/files/issues/broken-update-module-help-links_1.patch

--- modules/update/update.module	8 Jan 2008 10:35:43 -0000	1.8
+++ modules/update/update.module	9 Jan 2008 08:46:27 -0000

now, the patch knows where the file lives, so you can start from the root, and use "patch -p0 < foo" and it works.

happy patching,
-derek

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.