Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']
Remove all entries:

core/modules/content_translation/content_translation.module:      'uid' => $GLOBALS['user']->id(),
core/modules/content_translation/lib/Drupal/content_translation/ContentTranslationController.php:      $name = $new_translation ? $GLOBALS['user']->name : user_load($entity->translation[$form_langcode]['uid'])->name;
core/modules/content_translation/lib/Drupal/content_translation/Tests/ContentTranslationSyncImageTest.php:        'uid' => $GLOBALS['user']->id(),
CommentFileSizeAuthor
#19 2078057-19-global-user-content-translation.patch1.41 KBjoelpittet
#16 2078057-16.patch2.79 KBareke
#10 entity-refenrence-user-current_user-service-instead-of-global-user-2097671-3.patch1.97 KBm1r1k
#10 interdiff.txt420 bytesm1r1k
#8 content-translation-remove-global-user-from-translation-module-2078057-8.patch2.36 KBm1r1k
#6 node-use-current_user-service-instead-of-_account-attr-2095641-3.patch685 bytesm1r1k
#4 content-translation-remove-global-user-from-translation-module-2078057-4.patch2.79 KBm1r1k
#1 content-translation-remove-global-user-from-translation-module-2078057-1.patch169 KBm1r1k
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Active » Needs review
FileSize
content-translation-remove-global-user-from-translation-module-2078057-1.patch169 KB

Here is a patch. Depends on #2076411: Remove the request scope from the current user service

Status: Needs review » Needs work

The last submitted patch, content-translation-remove-global-user-from-translation-module-2078057-1.patch, failed testing.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented

Oh, wrong patch, I'll post correct one shortly

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Needs work » Needs review
FileSize
content-translation-remove-global-user-from-translation-module-2078057-4.patch2.79 KB

Here is patch

Status: Needs review » Needs work

The last submitted patch, content-translation-remove-global-user-from-translation-module-2078057-4.patch, failed testing.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Needs work » Needs review
FileSize
node-use-current_user-service-instead-of-_account-attr-2095641-3.patch685 bytes

Weird, but it works nice on my local, lets try to retest. Also upload new patch with correct name:

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Needs review » Needs work

Sorry, wrong patch.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Needs work » Needs review
FileSize
content-translation-remove-global-user-from-translation-module-2078057-8.patch2.36 KB

Re-roll after #2053489: Standardize on \Drupal throughout core

Status: Needs review » Needs work

The last submitted patch, content-translation-remove-global-user-from-translation-module-2078057-8.patch, failed testing.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
FileSize
interdiff.txt420 bytes
entity-refenrence-user-current_user-service-instead-of-global-user-2097671-3.patch1.97 KB

Try with removed request: scope for current_user service

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Needs work » Needs review

Push to retesting

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Assigned: m1r1k » Unassigned
Status: Needs review » Postponed
Issue tags: +blocked-by-request-scope
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Postponed » Needs review
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

#8: content-translation-remove-global-user-from-translation-module-2078057-8.patch queued for re-testing.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

#10 looks like the wrong patch, but #8 is dead on. If #8 comes back green it's ready to be RTBC.

areke’s picture

areke CreditAttribution: areke commented
Issue summary: View changes
FileSize
2078057-16.patch2.79 KB

@joelpittet You're right. #10 is wrong. I re-rolled the patch at #8 because it's the patch we're looking for.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs review » Reviewed & tested by the community

Perfect! Thanks I think this is good to go:) Checked there was no remaining in the content translation module and it passes testbot. Thanks @areke

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Needs work

No longer applies.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs work » Needs review
FileSize
2078057-19-global-user-content-translation.patch1.41 KB

Re-roll of #16, auto merged.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs review » Reviewed & tested by the community

Setting this back to RTBC because I double checked the re-roll and there is no other changes necessary.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

19: 2078057-19-global-user-content-translation.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.