This might win me The Most Trivial Patch of the Month Award :P


The library definition in system.module already declares its dependencies correctly:

  $libraries['drupal.tableselect'] = array(
    'title' => 'Tableselect',
    'version' => VERSION,
    'js' => array(
      'core/misc/tableselect.js' => array(),
    ),
    'dependencies' => array(
      array('system', 'drupal'),
      array('system', 'jquery'),
    ),
  );

So it's really only

(function ($) {
…
})(jQuery);

that is wrong: it should also list Drupal.

CommentFileSizeAuthor
tableselect_closure_drupal.patch440 bytesWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Trivival.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.