Move FAPI callbacks for file/image widgets in classes

Let me try :)

Voilà!

To be honest, even now I'm not sure how to pass by reference with call_user_func_array() in 5.3 compared to 5.4. This works on PHP 5.4, let's see the bot.

+++ b/core/modules/file/lib/Drupal/file/Plugin/field/widget/FileWidget.php
@@ -258,4 +259,265 @@ public function massageFormValues(array $values, array $form, array &$form_state
+    // If there are more files uploaded via the same widget, we have to separate
+    // them, as we display each file in it's own widget.
+    $new_values = array();
+    foreach ($submitted_values as $delta => $submitted_value) {
+      if (is_array($submitted_value['fids'])) {
+        foreach ($submitted_value['fids'] as $fid) {
+          $new_value = $submitted_value;
+          $new_value['fids'] = array($fid);
+          $new_values[] = $new_value;
+        }
+      }
+      else {
+        $new_value = $submitted_value;
+      }
+    }
+

I just copied this piece of code from the legacy callback but looking a little bit inside it doesn't look good to me. Isn't this wrong? I mean the "else" part $new_value = $submitted_value;? It seems that we drop out the submitted value when $submitted_value['fids'] is not an array?

image

7: file-widget-callbacks-2072995-7.patch queued for re-testing.

Reworked the patch. The interdiff is not relevant as the patch was seriously outdated. @yched please check also the comment from #8.

Looks fine to me.

11: file-widget-callbacks-2072995-11.patch queued for re-testing.

rerolled

17: file-widget-callbacks-2072995-17.patch queued for re-testing.

This patch has been in the reroll-and-RTBC cycle for more than four weeks, so tagging accordingly.

d.o doesn't like the + apparently.

No reroll needed that I can see, testbot ran out of disk space on the last run.

17: file-widget-callbacks-2072995-17.patch queued for re-testing.

Needs re-RTBC, @yched?

Committed and pushed to 8.x.

We'll need a change notice for this.

Change Record created.

Hi yched,

Thank you for the mentoring! Am not a very technical person, but wanted to pitch in...:)

Have added the issue to the change record (was having an issue with the auto-complete, the auto-complete text appears at the top of the screen and not below the field).

Will try and understand the other two recommendations and make the corrections as soon as I get the hang of it.

Jaya

Tagging "Missing change record", as completing the change record updates here blocks a beta: #2083415: [META] Write up all outstanding change notices before release

Marking "Needs work" to incorporate @yched's feedback in the change record.

Change record is there, just needs a bit more tweaking.

Mm, fileWidget contains an unused variable on line 519 ($new_value).
Also, if you set images to multiple (or at least unlimited in our testing), it somehow forgets it's multiple and the widget printing looks bad.
Coming from #2172241: Files and image widgets completely broken which plopsec was investigating the file validation there, but also stumbled on the fact that valid images/files are now bad too when being multiple. Note that we're not sure yet if this issue caused that second regression.

Just unassigning issues that haven't been developed for a bit in the D8 queue.

Updated the change notice. Back to RTBC for closing.

I think "Fixed" is better :)