Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/file/lib/Drupal/file/Tests/FileFieldRevisionTest.php

Line 86: Unused local variable $node_vid_r4

CommentFileSizeAuthor
#3 2072557-3.patch902 byteskshm
#1 core-remove-unused-vars-filefieldrevisiontest.php-2072557-1.patch941 byteslegolasbo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Assigned: legolasbo » Unassigned
Status: Active » Needs review
FileSize
core-remove-unused-vars-filefieldrevisiontest.php-2072557-1.patch941 bytes

Removed unused local variable

phiit’s picture

phiit CreditAttribution: phiit commented
Assigned: Unassigned » phiit
Status: Needs review » Needs work
Issue tags: +Needs reroll

The patch fixes the unused variable issue but needs a reroll.

kshm’s picture

kshm CreditAttribution: kshm commented
Assigned: phiit » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2072557-3.patch902 bytes

Re-rolled

phiit’s picture

phiit CreditAttribution: phiit commented
Status: Needs review » Reviewed & tested by the community

Patch applies and reviewed, thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.