Menu items do not save if the menu path is an alias.

Adding tag

grep -ir "but will use the URL" core
core/modules/menu_link/lib/Drupal/menu_link/MenuLinkFormController.php:      drupal_set_message(t('The menu system stores system paths only, but will use the URL alias for display. %link_path has been stored as %normal_path', array('%link_path' => $menu_link->link_path, '%normal_path' => $normal_path)));

Definitely no test coverage

Hi guys,

The problem is when submitting the form, we generate an entity using the form values. Maybe we should alter the form_state value?

Cheers.

If we have query parameters the patch doesn't work because we are adding values to the $menu_link object into the validation.

We still need tests here

I think the place to detect this is from MenuTest.php where we add/remove menu links. I was trying today on a break, but I need more time.

When adding the new path with a query, the path is added complete to the "link_path" and to reproduce the same behavior as D7 does, the query should be added to "options" as I can verify.

So I change the status to needs work.

After applying the patch 2063191-menulinks.patch by marthinal in #3 to a Drupal 8 fresh install 8/17, adding a menu link from an alias, which was previously not saving, is now saving to the menu.

adding tests

Adds tests.
Should be red/green

@larowlan Seems to work as expected with a query using this patch.

Thanks for the test. I was starting the test when I saw your test :)

Working on passing patch

Fixes test fail at #9
Interdiff is against 9.

Less fragile test, doesn't rely on node/5

So @marthinal are you saying we need to handle links to aliases with parameters as well? eg foobar?bar=baz which is an alias to node/1?bar=baz ?

I was able to reproduce the bug. Patch #14 fixed it. See screenshots attached.

got the same issue,I just tried and it helped. thanks :)

Committed/pushed to 8.x, thanks!

I'm getting this in Drupal 7. Will there be a patch for 7?

Also having this problem in D7. I would appreciate a patch too.

@matt.rad: See https://www.drupal.org/node/2715157

Please check your linked content page is published or not?