Updated: Comment #4

Problem/Motivation

The taxonomy edit form is still not a route, so let's convert it to be able to make progress on #1857256: Convert the taxonomy listing and feed at /taxonomy/term/%term to Views

There is a test which checks that additional not-used variables aren't interpretated by entity_get_form. In the new routing system additional unused arguments leads to a 404,
so the test is quite pointless.

CommentFileSizeAuthor
#3 vdc-2062769-3.patch2.41 KBdawehner
#3 interdiff.txt990 bytesdawehner
#1 taxonomy-2062769-1.patch1.44 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
taxonomy-2062769-1.patch1.44 KB

There we go

Status: Needs review » Needs work

The last submitted patch, taxonomy-2062769-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
interdiff.txt990 bytes
vdc-2062769-3.patch2.41 KB

There is a test which checks that additional not-used variables aren't interpretated by entity_get_form. In the new routing system additional unused arguments leads to a 404,
so the test is quite pointless.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Nice, that test actually results in exceptions in the apache log on testservers. There's an issue somewhere by jthorson to remove it I think already.

Check taxonomy.admin.inc, there's unfortunately nothing to remove there, definition was already useless before.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

#3: vdc-2062769-3.patch queued for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed a19dfc6 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

described test