Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/lib/Drupal/Core/Config/Entity/ConfigStorageController.php

Line 354: Unused local variable $id
Line 358: Unused local variable $id
Line 364: Unused local variable $id

CommentFileSizeAuthor
#1 drupal-remove-unused-var-2062221-1.patch1007 bytesduozersk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
CreditAttribution: duozersk commented
Assigned: duozersk » Unassigned
Status: Active » Needs review
FileSize
drupal-remove-unused-var-2062221-1.patch1007 bytes

Status: Needs review » Needs work
Issue tags: -Novice, -CodeSprintCIS

The last submitted patch, drupal-remove-unused-var-2062221-1.patch, failed testing.

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
CreditAttribution: duozersk commented
Status: Needs work » Needs review
Issue tags: +Novice, +CodeSprintCIS

#1: drupal-remove-unused-var-2062221-1.patch queued for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Also method importDelete() needs follow-up to check arguments that seems unused

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed ac77a52 and pushed to 8.x. Thanks!

I don't thing importDelete() needs a followup because its arguments are consistent with the other import.* functions which means the config importer can care less about how it needs to invoke the import.* functions.

Automatically closed -- issue fixed for 2 weeks with no activity.