Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/lib/Drupal/Core/Entity/DatabaseStorageController.php

Line 300: Unused local variable $key
Line 398: Unused local variable $id
Line 417: Unused local variable $id

File /core/lib/Drupal/Core/Entity/DatabaseStorageControllerNG.php

Line 192: Unused local variable $key
Line 282: Unused local variable $id
Line 579: Unused local variable $id
Line 604: Unused local variable $id

File /core/lib/Drupal/Core/Entity/EntityNG.php

Line 618: Unused local variable $name

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

duozersk’s picture

Assigned: duozersk » Unassigned
Status: Active » Needs review
FileSize
4.03 KB

Status: Needs review » Needs work
Issue tags: -Novice, -CodeSprintCIS

The last submitted patch, drupal-remove-unused-var-2062191-1.patch, failed testing.

duozersk’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal-remove-unused-var-2062191-1.patch, failed testing.

andypost’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +CodeSprintCIS
andypost’s picture

Status: Needs review » Reviewed & tested by the community

Seems bots are bored by our sprint

alexpott’s picture

Title: Remove Unused local variable $key from /core/lib/Drupal/Core/Entity/DatabaseStorageController.php » Remove Unused local variables from EntityNG, DatabaseStorageControllerNG, and DatabaseStorageController
Status: Reviewed & tested by the community » Fixed

Committed 5251459 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.