Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']

core/modules/node/lib/Drupal/node/Access/NodeRevisionAccessCheck.php
fix of $account = $GLOBALS['user'];

CommentFileSizeAuthor
#5 node-revision-access-check-remove-global-user-2062117-5.patch641 bytesm1r1k
#3 2062117-3.patch666 bytesanpolimus
#2 2062117-2.patch665 bytesanpolimus
#1 2062117-1.patch666 bytesanpolimus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
CreditAttribution: anpolimus commented
FileSize
2062117-1.patch666 bytes

REplaced global $user with get account method.

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
CreditAttribution: anpolimus commented
FileSize
2062117-2.patch665 bytes

test2

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
CreditAttribution: anpolimus commented
Status: Active » Needs review
FileSize
2062117-3.patch666 bytes

replased with new \Drupal::request()->attributes->get('_account');

Status: Needs review » Needs work

The last submitted patch, 2062117-3.patch, failed testing.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
FileSize
node-revision-access-check-remove-global-user-2062117-5.patch641 bytes

Re-roll after #2076411: Remove the request scope from the current user service

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Needs work » Needs review

Push to retesting

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Assigned: anpolimus » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

This one looks good to go and applies cleanly as of today.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.