API page: https://api.drupal.org/api/drupal/core%21modules%21field%21field.module/...

The page contains the following text:

  • Do not use inside node (or other entities) templates, use render($content[FIELD_NAME]) instead.
  • Do not use to display all fields in an entity, use field_attach_prepare_view() and field_attach_view() instead.
  • The field_view_value() function can be used to output a single formatted field value, without label or wrapping field markup.

The first two sentences are comma-splices. There should be a but after the comma, or the comma should simply be replaced with a semicolon.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

apaderno’s picture

Status: Active » Needs review
FileSize
1.13 KB

For what I recall, in American English the items of a list should not have a period at the end.

apaderno’s picture

Issue summary: View changes

Only two sentences are comma-splices.

Status: Needs review » Needs work

The last submitted patch, fix-comma-splice-2059785-2.patch, failed testing.

apaderno’s picture

Status: Needs work » Needs review
FileSize
876 bytes
longwave’s picture

While we are here, "node (or other entities) templates" seems like it needs changing as well; maybe "node (or any other entity) templates"?

apaderno’s picture

That's right; in that way, the attributive is a singular noun as it should be, and as node is.

Status: Needs review » Needs work

The last submitted patch, fix-comma-splice-2059785-6.patch, failed testing.

apaderno’s picture

Status: Needs work » Needs review

#6: fix-comma-splice-2059785-6.patch queued for re-testing.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

RTBC, no reason why this should fail!

jhodgdon’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs backport to D7, +Needs reroll

Patch no longer applies. :(

longwave’s picture

Status: Needs work » Needs review

Still applies for me, with no fuzz even.

#6: fix-comma-splice-2059785-6.patch queued for re-testing.

jhodgdon’s picture

Status: Needs review » Fixed
Issue tags: -Needs reroll

Oh, you're right! Not sure what happened before.

Committed to 8.x and 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Fixed grammar.