Drupal 8 lost support for the 'tel' protocol in URL filtering functions [#2058435]

Background:
#945332: Allow "tel:" protocol through drupal_strip_dangerous_protocols
#2026269: Different default values for filter_allowed_protocols variable

Drupal 8 seems to have lost support for 'tel' entirely, I think as a side effect of #1799440: Convert Filter variables to Configuration System.

Comment	File	Size	Author
#1	d8-tel-protocol-2058435-1.patch	335 bytes	David_Rothstein
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

David_Rothstein CreditAttribution: David_Rothstein commented 6 August 2013 at 03:30

Status:

Active

» Needs review

File	Size
d8-tel-protocol-2058435-1.patch	335 bytes

Presumably this patch is all that's needed.

It would be good to alphabetize them also (like in Drupal 7) but for ease of review I haven't bothered...

Comment #2

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 6 August 2013 at 12:23

Should we add a test too?

Comment #3

Damien Tournoud CreditAttribution: Damien Tournoud commented 6 August 2013 at 13:10

Status:

Needs review

» Reviewed & tested by the community

This is a side-effect of #2026269: Different default values for filter_allowed_protocols variable, already fixed in Drupal 7 (in violation of the backporting protocol...).

Let's get this in for Drupal 8. And no, please don't add tests for configuration values.

Comment #4

David_Rothstein CreditAttribution: David_Rothstein commented 7 August 2013 at 05:56

Issue tags:

+Regression

#2026269: Different default values for filter_allowed_protocols variable wasn't really relevant for Drupal 8 since it was about fixing an inconsistency (between two different URL filtering functions), but in Drupal 8 there is only one place this information is stored so no way to be inconsistent. In Drupal 8 the configuration is just gone entirely (caused by #1799440: Convert Filter variables to Configuration System) and thus both uses are currently broken.

Drupal 8 does have a regression here though, so adding a tag to track this (I don't think it's likely this issue will linger, but just in case we don't want to forget it).