Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I was going to add test coverage over in #2046993: Inject dependencies into ViewsExposedFilterBlock derivative class, but in starting to do so realised that exposed blocks don't actually work at all at the moment. This is not a problem with the deriver but with the actual ViewsExposedBlock block plugin.
Test coverage should be added here instead.
Steps to reproduce:
- Create view, add page display
- Under 'advanced' change 'Exposed form in block' setting to yes
- Save
- Try to place this new exposed block
- Watch things break
Comment | File | Size | Author |
---|---|---|---|
#8 | 2057831-8.patch | 15.3 KB | damiankloip |
#8 | interdiff-2057831-8.txt | 595 bytes | damiankloip |
#2 | 2057831-2-tests-only.patch | 4.72 KB | damiankloip |
#2 | 2057831-2.patch | 15.29 KB | damiankloip |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commented.
Comment #2
damiankloip CreditAttribution: damiankloip commentedComment #3
dawehnerI really like to split up the functionality of the two kind of views blocks!
The signature and documentation seem to disagree.
Comment #4
dawehnerI really like to split up the functionality of the two kind of views blocks!
The signature and documentation seem to disagree.
Comment #6
damiankloip CreditAttribution: damiankloip commented#2: 2057831-2.patch queued for re-testing.
Comment #7
dawehnerThe @param talks about ViewStorageInterface, but the function has ViewExecutable!
Comment #8
damiankloip CreditAttribution: damiankloip commentedGood call, that line just doesn;t match :)
Comment #9
dawehnerI really like having a new test for that bit.
Comment #10
webchickThat sounds much worse than a "normal" bug. :)
I'll need some help walking through this patch on IRC or whatever, since after 3 months off I'm not up to speed on the new way blocks are defined and stuff. Else, we can just leave it for Alex/catch/Dries.
Comment #11
dawehnerExposed filters as a block is certainly not a often used functionality. I guess most of us will be online later anyway.
Comment #12
catchReviewed this, looks like good cleanup as well as the bug fix.
Committed/pushed to 8.x, thanks!
Comment #13.0
(not verified) CreditAttribution: commentedUpdated issue summary.