Regular forms cannot be submitted when used as modal forms

Looks like prepareDialogButtons in core/misc/dialog.ajax.js is the issue here so that went in with #1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms from memory.
If I add

return;

to the start of that function, we get back our standard submit handler.
I've stepped through the code (you need to add debugger; at the start of the function (instead of return;) to get the debugger to work with chrome (and you might need to add //@ sourceURL=dialog.ajax.js to the top of your file depending on your version - it looks as though the event listener is attaching to proxy the dialog submit to the original submit button but it ain't working, nothing is triggered.
But it doesn't work.
To test
enable ajax_test
head to ajax-test/dialog
Click the 'entity form' link
Try and save the contact category

Javascript and tests don't play nice do they :(

The patch will touch a javascript file, tagging accordingly. Please remember to tag "JavaScript" so that JS maintainers are able to review JS patches and avoid situations like #2057371: Re-Replace all $.each() with filtered for loop. Thanks.

#1: You'll want to pull in quicksketch for this, since he wrote core/misc/dialog.ajax.js's Drupal.behaviors.dialog.prepareDialogButtons(). I'm not familiar with all the Dialog subtleties.

Adding Spark tag.

One assigns forces the new button to trigger the original button, the second one (which I've deleted) is responding to submit.dialogSubmit, whatever that is.

.on('submit.dialogSubmit') is the same thing as just saying .on('submit'), the ".dialogSubmit" part is a namespacing for the binding so you can remove it individually if needed.

I'm not sure this code is needed any more. Previously it was in place to ensure that using the enter key to submit the form would click the first button. However then we switched to the 0 width/height/padding/border approach (http://mattsnider.com/how-forms-submit-when-pressing-enter/) instead of hiding the buttons with display: none.

I remember having some specific problems around keeping the dialog-behaviors working after a validation error occurred within a dialog. After commenting-out/removing this code, can you try to use the WYSIWYG dialog for inserting an image, but leave the URL empty? That should throw a validation error. Then try inserting a URL and making sure that the form still operates properly after the failed validation. If that particular problem doesn't come back with this code removed, I think it indicates this is left-over cruft from a previous attempt at getting the enter-key to behave correctly.

Validation works as expected, there is no functionality (without building #ajax into your form) for validation to return to the modal, it should redirect to the form's #action by default.
In light of that, rtbc

Nice find, I'm good with it.

Less code++

Validation works as expected, there is no functionality (without building #ajax into your form) for validation to return to the modal, it should redirect to the form's #action by default.

Hi guys, just making sure I'm understanding this correctly. In the case of the editor image dialog:
- The Image dialog should have the URL field required.
- When you submit the form but it's empty, it should display the validation message, "The URL field is required" inside the dialog after AJAX submission fails, without page reloading or redirecting.

But for a *normal* form displayed in a dialog, that's right, there is no built-in ability to display validation inside the dialog. It must be done by adding an #ajax behavior to your form. A form in a dialog is just a form in a dialog right now, so special auto-ajax is added. Submission and validation must be manually added via #ajax if you want to keep the dialog open.

I don't understand why we'd remove the detach callback

-    detach: function (context, settings) {
-      $(context).find('form').off('submit.dialogSubmit');
-    },

nod_ points out that this patch removes the only instance of submit.dialogSubmit, so the detach callback isn't needed any more either.

Tested and it's good to go.

When I add explicit FAPI-based validation, it behaves as expected.

Great. RTBC +1. Sorry for the cruft in the original patch. :)

Yay less code! :)

Committed and pushed to 8.x. Thanks!