FieldInstanceFormBase is only extended by FieldInstanceEditForm, the two should be merged ?
Unneeded abstraction --.

CommentFileSizeAuthor
#5 2050367-5.patch5.75 KBamateescu
#5 interdiff.txt603 bytesamateescu
#2 2050367.patch5.73 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue tags: +API clean-up

Makes sense

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Active » Needs review
FileSize
2050367.patch5.73 KB

Yep, it's totally useless. I was wondering the same thing recently while I was working on another issue, so I'm glad you opened this one.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Thanks !
RTBC if green.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2050367.patch, failed testing.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs work » Reviewed & tested by the community
FileSize
interdiff.txt603 bytes
2050367-5.patch5.75 KB

Just missing a 'use' statement.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Title: FieldInstanceFormBase is useless ? » FieldInstanceFormBase is useless
Status: Reviewed & tested by the community » Fixed

Committed 94cf43e and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.