#2005166: Create simple file listing under admin/content/file added two views:
admin/content/files for an overview
admin/content/files/usage/% for a single file's usage info

These were added as two separate views, but they should have been a single view with two displays.

While rebuilding this, I noticed the breadcrumbs were broken for the file usage view.
I found that fix, which can be split out if needed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
19.92 KB
15.9 KB
23.14 KB

Before:
before.png

After:
after.png

dawehner’s picture

+++ b/core/modules/file/config/views.view.files.ymlundefined
@@ -571,6 +598,360 @@ display:
+        type: full

Let's use the minipager.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/display/PathPluginBase.phpundefined
@@ -178,10 +178,6 @@ public function executeHookMenu($callbacks) {
       switch ($menu['type']) {
-        case 'none':
-        default:
-          $items[$path]['type'] = MENU_CALLBACK;
-          break;

Isn't that really out of scope?

tim.plunkett’s picture

FileSize
22.55 KB
423 bytes

admin/content/node uses full pager as well, and mini always says "Page 1" even if there are no more pages... So not switching.

Also mimicking the admin/content/node by hiding the contextual links.

Moved that hunk to #2049585: Views page displays with placeholders are forced to be MENU_CALLBACK

dawehner’s picture

dawehner’s picture

Let's go with that for now. In general I think we should try to get contextual links enabled, as this is really a power feature!

tim.plunkett’s picture

FileSize
1.83 KB
22.48 KB

That went in.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 0a5c786 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.