Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This could be quite a big patch and need a few re-rolls so the sooner we can get this in the better.
Meta Issue.
#1916134: Remove module_* deprecated functions
Comment | File | Size | Author |
---|---|---|---|
#11 | replace-module-hook-2045935-11.patch | 6.54 KB | benjy |
#8 | replace-module-hook-2045935-8.patch | 5 KB | benjy |
#4 | replace-module-hook-2045935-4.patch | 4.8 KB | benjy |
#2 | replace-module-hook-2045935-2.patch | 4.91 KB | benjy |
Comments
Comment #1
benjy CreditAttribution: benjy commentedTagging
Comment #2
benjy CreditAttribution: benjy commentedComment #3
alexpottCareful with including unrelated change...
Comment #4
benjy CreditAttribution: benjy commentedGood spot, that was trying to re-install the other day. New patch attached.
Comment #5
Sam152 CreditAttribution: Sam152 commentedI'm brand new to core development but the above patch looks good to me. Not sure if it should be recreated to respect the 80 character comment limited as per:
// this can quickly lead to Drupal::moduleHandler()->implementsHook() being called several thousand times
But other than that, looks fine to me.
Comment #6
Sam152 CreditAttribution: Sam152 commentedComment #7
claudiu.cristeaOnly coding standards comments:
Line too long, wrap to 80 characters. See https://drupal.org/node/1354.
Same here.
Comment #8
benjy CreditAttribution: benjy commentedNew patch attached.
Comment #9
benjy CreditAttribution: benjy commentedSettings back to RTBC since it was just a comment change.
Comment #10
catchModuleHandler::invoke() already calls implementsHook() and returns NULL if nothing's there, so we should remove it altogether.
Again this is also checked internally by module_invoke().
Comment #11
benjy CreditAttribution: benjy commentedThanks, I wasn't aware of that check. New patch attached.
Comment #12
catchComment #13
benjy CreditAttribution: benjy commentedany reason this still needs work?
Comment #14
catchNope, I forgot to change status with #10, then crossposted with #11.
Comment #15
benjy CreditAttribution: benjy commentedSetting back.
Comment #16
catchCommited/pushed to 8.x, thanks!