memcache_admin.module display Total Evictions unformatted.

CommentFileSizeAuthor
#6 memcache-remove-orig-file-2045353-6.patch22.02 KBmarkpavlitski
#1 eviction-number-display-2045353-1.patch678 bytesDeeZone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DeeZone’s picture

DeeZone CreditAttribution: DeeZone commented
Status: Active » Patch (to be ported)
FileSize
eviction-number-display-2045353-1.patch678 bytes

Patch to address issue.

markpavlitski’s picture

markpavlitski CreditAttribution: markpavlitski commented
Status: Patch (to be ported) » Needs review
markpavlitski’s picture

markpavlitski CreditAttribution: markpavlitski commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Patch looks good and I can't see any downside to this fix.

markpavlitski’s picture

markpavlitski CreditAttribution: markpavlitski commented
Issue tags: +needs backport to 6.x

Adding backport tag as this issue exists in 6.x too.

Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to Drupal 7:
http://drupalcode.org/project/memcache.git/commitdiff/f2f0db0

And back ported to Drupal 6:
http://drupalcode.org/project/memcache.git/commitdiff/4a997b0

markpavlitski’s picture

markpavlitski CreditAttribution: markpavlitski commented
Status: Fixed » Needs review
FileSize
memcache-remove-orig-file-2045353-6.patch22.02 KB

Sorry to reopen this issue, but there was an unnecessary file introduced in the 7.x commit, memcache_admin/memcache_admin.module.orig.

The attached patch removes that file.

Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented
Status: Needs review » Fixed

Yikes -- it doesn't pay to hurry! Thanks for the patch.

Committed:
http://drupalcode.org/project/memcache.git/commitdiff/03584ea

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.