Because they are crammed together

In file.admin.css:

.form-managed-file .form-file, .form-managed-file .form-submit {
- margin: 0;
+ margin: 0 .5em 0;
}

and yes, I am that picky.

(sorry I didn't roll a patch, I'm a designer :) )

CommentFileSizeAuthor
#12 file-2041625-12.patch391 bytestim.plunkett
#11 2041625smallscreen.png47.35 KBandymartha
#10 Before38.87 KBjOksanen
#10 After41.16 KBjOksanen
#7 CSS-2041625-7.patch392 bytesvineet.osscube
#2 CSS-2041625-2.patch391 bytesvineet.osscube
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vineet.osscube’s picture

vineet.osscube CreditAttribution: vineet.osscube commented
Assigned: Unassigned » vineet.osscube
vineet.osscube’s picture

vineet.osscube CreditAttribution: vineet.osscube commented
FileSize
CSS-2041625-2.patch391 bytes

Attached patch for the same.

Status: Needs review » Needs work

The last submitted patch, CSS-2041625-2.patch, failed testing.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary commented

@vineet.osscube

Thanks!

vineet.osscube’s picture

vineet.osscube CreditAttribution: vineet.osscube commented

@tkoleary,
Patch failed in browser group testing. Can you check once again and suggest css code?

falc0’s picture

falc0 CreditAttribution: falc0 commented

I think you have a small typo in your patch:

+ margin: 0.5em 0;

should be

+ margin: 0 .5em 0;
vineet.osscube’s picture

vineet.osscube CreditAttribution: vineet.osscube commented
Status: Needs work » Needs review
FileSize
CSS-2041625-7.patch392 bytes

Correct and attached patch for the same.

vineet.osscube’s picture

vineet.osscube CreditAttribution: vineet.osscube commented

@falc0

Thanks

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Can we gets screens (before after?)
After all this is a frontend issue.

jOksanen’s picture

jOksanen CreditAttribution: jOksanen commented
FileSize
After41.16 KB
Before38.87 KB

Images as requested.

andymartha’s picture

andymartha CreditAttribution: andymartha commented
Status: Needs review » Reviewed & tested by the community
FileSize
2041625smallscreen.png47.35 KB

After applying the patch CSS-2041625-7.patch by vineet.osscube in #7 to a Drupal 8 fresh install 8/9 , I confirm the space is there and nothing breaks (not too much to break). Attached is a small screen screenshot to go with #10

2041625smallscreen.png

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
file-2041625-12.patch391 bytes

Functionally identical, just adhering to coding standards.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Cool, this has been annoying me, too. :)

Committed and pushed to 8.x. Thanks!

tkoleary’s picture

tkoleary CreditAttribution: tkoleary commented

Another small win. Let's keep em rolling!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.