The plugin API now automatically populates the module name in a 'provider' entry in plugin definitions.
We should remove the explicit 'module' entry present in existing plugins, and move business code to check $plugin_definition['provider'] rather than ['module']

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

Done for widgets in #2035315: Add a dedicated @FieldWidget annotation
Needs to be done for formatters and field types

fago’s picture

Issue tags: +Entity Field API

Just stumbled upon that issue - so tagging.

yched’s picture

Status: Active » Needs review
Issue tags: +Field API
FileSize
26.96 KB

Let's see how this goes.

Status: Needs review » Needs work
Issue tags: -Field API, -Entity Field API

The last submitted patch, field_plugin_provider-2041423-3.patch, failed testing.

plopesc’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Field API, +Entity Field API

The last submitted patch, field_plugin_provider-2041423-3.patch, failed testing.

yched’s picture

Status: Needs work » Needs review
FileSize
845 bytes
27.78 KB

Should be better.

Status: Needs review » Needs work

The last submitted patch, field_plugin_provider-2041423-7.patch, failed testing.

yched’s picture

Status: Needs work » Needs review
FileSize
719 bytes
28.48 KB

Status: Needs review » Needs work

The last submitted patch, field_plugin_provider-2041423-9.patch, failed testing.

yched’s picture

Status: Needs work » Needs review
FileSize
3.71 KB
31.63 KB

Status: Needs review » Needs work

The last submitted patch, field_plugin_provider-2041423-11.patch, failed testing.

yched’s picture

Status: Needs work » Needs review
FileSize
1.68 KB
33.31 KB

Hopefully we should be good now.

amateescu’s picture

Status: Needs review » Reviewed & tested by the community

Yes we are :)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 1149597 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.