Add public identifier to all render methods in all views plugins in core

note, there is also: > core/lib/Drupal/Component/Diff/DiffEngine.php:1244: function render() {
separate issue?

done by

ag " function render\(" core | grep -v public | grep view | cut -f1 -d":" > ~/filelist.txt

$ cat ~/script.sh 
#!/bin/sh
for x in `cat ~/filelist.txt `
do
sed "s/ function render(/ public function render(/" $x > temp
cat temp > $x
done

~/script.sh

there were 64 files that were effected.

git diff | grep diff | wc -l

Committed 31efff2 and pushed to 8.x. Thanks!

So this is fixed

Do we care that AreaPluginBase and PagerPluginBase have inconsistent declarations? The former has

  public abstract function render($empty = FALSE);

and the latter has

  public function render($input) { }

BTW, what is the "ag" utility mentioned in #3, some "grep -r" variant?

Thanks for the pointer to ag.

I was wondering more about declaring just one as abstract. Both classes are declared as abstract, so why does one method get declared as abstract and not the other? I do not know PHP well enough to know whether this is a significant difference, or entirely equivalent. If the latter, then consistency would be clearer.