Follow up for #1641166: Undefined property: Drupal\Core\Language\Language::$locked in language_list()
Updated: Comment #0
Problem/Motivation
Docs are missing for properties.
https://drupal.org/node/1354#var
Proposed resolution
Add the docs.
Remaining tasks
- write the patch, https://drupal.org/contributor-tasks/create-patch
- come up with good words
User interface changes
No.
API changes
No.
Related Issues
- #2031277-6: Implement checkCreateAccess on LanguageAccessController
- #1641166: Undefined property: Drupal\Core\Language\Language::$locked in language_list() added the locked property out the docs
- #1497230-91: Use Dependency Injection to handle object definitions added the class without property docs on other properties
- #1512424: Add a LanguageInterface, and property setters/getters to Language class
Comment | File | Size | Author |
---|---|---|---|
#3 | drupal8.language-system.2035007-3.patch | 1.59 KB | tte |
#1 | drupal8.language-system.2035007-1.patch | 1.59 KB | YesCT |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedA first pass.
Needs review to see if the descriptions are actually accurate for what the properties are storing and why.
Comment #2
penyaskitoLooks good to me, but
default
could be clearer.Proposal:
Comment #3
tte CreditAttribution: tte commentedLooks good to me, too - as well as penyaskito's proposal.
Attached is a patch which combines both proposals.
Comment #4
YesCT CreditAttribution: YesCT commented@speely interdiffs are really cool.
Want to try making one?
instructions on creating an interdiff, see https://drupal.org/documentation/git/interdiff | Microbranching workflow: http://xjm.drupalgardens.com/blog/interdiffs-how-make-them-and-why-they-...
Comment #5
andypostLooks good to go
Comment #6
parthipanramesh CreditAttribution: parthipanramesh commentedGood work!
Comment #7
YesCT CreditAttribution: YesCT commentedstill applies.
Comment #8
jhodgdonChanging component so I notice it next time I am doing Core commits.
Comment #9
jhodgdonThanks all! Committed to 8.x.