CronForm does not access state properly.

CommentFileSizeAuthor
drupal-CronForm.patch1.47 KBelachlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

elachlan’s picture

elachlan CreditAttribution: elachlan commented

Test passed. A review would be nice so we can RTBC.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Looks good.

I already had a similar fix in #1786490: Add caching to the state system, which is the reason this is bad. That issue will replace the state service with a cache decorator, not using it but directly accessing the state collection circuments the cache invalidation logic.

It's just like trying to access a tempstore collection directly through the keyvalue expirable service, we have a specific service/API, so we need to use it consistently.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.