Just a tracking issue. I don't think any work has started on this, but I wanted to at least create an issue for people to subscribe to and where people could discuss efforts and perhaps post patches.

CommentFileSizeAuthor
#12 203223_comment_notify_6x_12.patch15.44 KBgreggles
#6 comment_notify_5.x-1.x-dev_6.x.patch9.52 KBYoran
#5 203223_comment_notify_6.x_upgrade.patch5.52 KBgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dennys’s picture

dennys CreditAttribution: dennys commented

subscribing

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

FWIW, I would like to sort out a bunch of the issues in the queue, create a 5.x-1.4, and only after that's been stable for a while do I think that a 6.x makes sense.

If (multiple) folks really want to have a 6.x now and would help with testing I'd be pursuaded to do it.

cantidubi’s picture

cantidubi CreditAttribution: cantidubi commented

Really necessary

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I'd like to get http://drupal.org/node/222740 finished before worrying about a 6.x port.

Also "really necessary"? if it's so necessary perhaps you could put up a bounty for the successful completion.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Active » Needs work
FileSize
203223_comment_notify_6.x_upgrade.patch5.52 KB

So, here's a start based on coder module. Since 6.x requires the schema module, I think that #232564: refactor data structure so core tables are not altered and move towards PostgreSQL compliance should be fixed first...

Yoran’s picture

Yoran CreditAttribution: Yoran commented
FileSize
comment_notify_5.x-1.x-dev_6.x.patch9.52 KB

I used your patch but there was some problem with locales and mail management in D6 API. I also had some incompatibility between you big query and Postgresql. So I modified the source in order to make it work with D6 and Psql. It's not a "good" patch as I didn't tryied to make it compatible with Postgresql and I just disconnected Locales. But perhaps this will help you to finish the migration.

Regards and thanks for this very important module !

Patch applies on your last dev version.

Fayna’s picture

Fayna CreditAttribution: Fayna commented

Subscribing so I can help test.

rapsli’s picture

rapsli CreditAttribution: rapsli commented

I'll test as soon as there's a first release ... alpha or pre alpha is fine.

hectorplus’s picture

hectorplus CreditAttribution: hectorplus commented

Subscribing

encho’s picture

encho CreditAttribution: encho commented

Subscribing

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

Hi folks. If you'd like to help move this forward I need reviews/testers for #232564: refactor data structure so core tables are not altered and move towards PostgreSQL compliance. That is important to get done prior to moving to Drupal6 due to the new Schema API module.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Version: 5.x-1.x-dev » 5.x-2.x-dev
Status: Needs work » Needs review
FileSize
203223_comment_notify_6x_12.patch15.44 KB

Ok...here's an updated version now that I've done the other things that I wanted to fix prior to an upgrade.

Note that this is a patch against the 5.x-2.x version of code (aka CVS HEAD) which hasn't yet been packaged and published, though it will be at http://drupal.org/node/288722 in a few hours...

Testers welcome!

Thanks.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

Note also that if you are upgrading from Drupal 5.x you will need to first upgrade to the comment_notify 5.x-2.x and run update.php prior to upgrading (the same as CCK does it).

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Assigned: Unassigned » greggles
Status: Needs review » Fixed

And...committed.

This may still have some bugs in it...but I'll be making a release soon.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Fixed » Needs work

Well...that patch missed a little bit. My initial testing seems to be that it's working, but all of the newlines are gone so I'll have to see how to add those back.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs work » Fixed

There's a new issue for the line break problem so I'm going to call this fixed. #299548: Line breaks not showing up in email

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.