Hi

Running Quiz 7.4-4.0-beta1. I've added some alternatives to a multichoice question and now I need to remove one alternative. I can't see an option anywhere. Am I missing something, or is the module missing something?

Thanks

David

CommentFileSizeAuthor
#21 quiz_cant_remove_multichoice_question_alternatives_2031973_21.patch5.41 KBdjdevin
#19 quiz_cant_remove_multichoice_question_alternatives_2031973_19.patch3.9 KBlintxa
#16 quiz_cant_remove_multichoice_question_alternatives_2031973_16.patch4.16 KBGlennDW
#13 quiz_cant_remove_multichoice_question_alternatives_2031973_7.patch3.95 KBGlennDW
#9 quiz_cant_remove_multichoice_question_alternatives_2031973_7.patch4.35 KBGlennDW
#6 quiz-cant_remove_multichoice_question_alternatives-2031973-6.patch3.82 KBsomersoft
#5 quiz-cant_remove_multichoice_question_alternatives-2031973-5.patch4.66 KBduynguyen
#4 quiz-cant_remove_multichoice_question_alternatives-2031973-4.patch4.19 KBduynguyen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kyuubi’s picture

kyuubi CreditAttribution: kyuubi commented
Issue summary: View changes

Hi!

I am having the same problem and the website is already live?

Is this a bug?

garphy’s picture

garphy CreditAttribution: garphy commented
Priority: Normal » Major

I think its a feature not currently implemented.

Raising to major as it seems that the module won't leave beta state without this feature.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented

Can someone give this a try with the 5.x version?

duynguyen’s picture

duynguyen CreditAttribution: duynguyen commented
FileSize
quiz-cant_remove_multichoice_question_alternatives-2031973-4.patch4.19 KB

I've a patch for this issue. hopeful it can help you guys

duynguyen’s picture

duynguyen CreditAttribution: duynguyen commented
FileSize
quiz-cant_remove_multichoice_question_alternatives-2031973-5.patch4.66 KB

re #4. the variable choice_count need to store in $form_state

somersoft’s picture

somersoft CreditAttribution: somersoft commented
FileSize
quiz-cant_remove_multichoice_question_alternatives-2031973-6.patch3.82 KB

The attached patch works with the 7.x-5.x-dev code.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin as a volunteer and at Cadmium commented
Version: 7.x-4.0-beta1 » 7.x-5.x-dev
Category: Bug report » Feature request
Status: Active » Needs review
Da_Cloud’s picture

Da_Cloud CreditAttribution: Da_Cloud at INDICIA commented
Status: Needs review » Needs work

I've applied the patch on the current dev release, but when I try to use the Remove button I'll end up with an AJAX error.

Watchdog logs the following:

EntityMalformedException: Missing bundle property on entity of type node. in entity_extract_ids() (line 7922 of /var/vhost/drupal7.dev/includes/common.inc).

GlennDW’s picture

GlennDW CreditAttribution: GlennDW as a volunteer and commented
FileSize
quiz_cant_remove_multichoice_question_alternatives_2031973_7.patch4.35 KB

I have changed it so that if you delete a choice and then save the node it will work. So if you delete a choice and refresh the page the choice will be back but if you delete it and then save the node it will work

GlennDW’s picture

GlennDW CreditAttribution: GlennDW as a volunteer and commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: quiz_cant_remove_multichoice_question_alternatives_2031973_7.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented

Your patch looks good, it just has to be re-rolled because it includes your sites/all/modules/contrib path.

Do you think you could add a test case too?

GlennDW’s picture

GlennDW CreditAttribution: GlennDW as a volunteer and commented
FileSize
quiz_cant_remove_multichoice_question_alternatives_2031973_7.patch3.95 KB

I have changed it

GlennDW’s picture

GlennDW CreditAttribution: GlennDW as a volunteer and commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: quiz_cant_remove_multichoice_question_alternatives_2031973_7.patch, failed testing.

GlennDW’s picture

GlennDW CreditAttribution: GlennDW as a volunteer and commented
Status: Needs work » Needs review
FileSize
quiz_cant_remove_multichoice_question_alternatives_2031973_16.patch4.16 KB

remade the patch

drupov’s picture

drupov CreditAttribution: drupov commented
Status: Needs review » Needs work

Work for me with 7.x-5.x-dev functional, but there is a php notice:

Notice: Undefined index: id in MultichoiceQuestion->getCreationForm() (line 584 of /home/d2x7a/www/sites/default/modules/quiz/question_types/multichoice/multichoice.classes.inc).

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review
lintxa’s picture

lintxa CreditAttribution: lintxa at Metadrop commented
FileSize
quiz_cant_remove_multichoice_question_alternatives_2031973_19.patch3.9 KB

The notice occurred because the multichoice_remove_alternative_submit function did not return the ids of the alternatives when rebuilding the $form_state.
Once added it seems to work correctly.

Please review.

lorenzs’s picture

lorenzs CreditAttribution: lorenzs at Cegeka commented
Status: Needs review » Reviewed & tested by the community

Tested in 5.2 and we use it for several months now in production.
Probably this could use an additional test but technically it's fine.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Reviewed & tested by the community » Needs review
FileSize
quiz_cant_remove_multichoice_question_alternatives_2031973_21.patch5.41 KB

I added a test.

Da_Cloud’s picture

Da_Cloud CreditAttribution: Da_Cloud at INDICIA commented
Status: Needs review » Reviewed & tested by the community

Tested the patch on a clean install and it correctly adds the remove button.

So based on comment #20 and the fact that there are also working test cases I'd say this patch is ready to be committed.

  • djdevin committed f3383e7 on 7.x-5.x authored by duynguyen 
    Issue #2031973 by ripz0r, duynguyen, djdevin, somersoft, lintxa,...
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Reviewed & tested by the community » Fixed

Thanks! Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.