When I was doing some work on #2002606: Allow themes to provide services.yml, I noticed a few minor coder issues that should probably be fixed.

CommentFileSizeAuthor
#1 drupal-drupalkernal.php-2031589-1.patch1.99 KBmarkhalliwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Status: Active » Needs review
FileSize
drupal-drupalkernal.php-2031589-1.patch1.99 KB

Patch

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Issue tags: +Novice, +Coding standards, +coder
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Component: other » base system
Issue tags: +kernel-followup
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Title: DrupalKernal.php coder review » DrupalKernel.php coder review
Issue tags: -Novice, -kernel-followup
TR’s picture

TR CreditAttribution: TR commented

#1: drupal-drupalkernal.php-2031589-1.patch queued for re-testing.

Coding standards issues are still there, patch still applies (with minor offsets). Let's see what the testbot says.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Reviewed & tested by the community

Passes tests, looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Issue tags: -Coding standards, -coder

#1: drupal-drupalkernal.php-2031589-1.patch queued for re-testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

1: drupal-drupalkernal.php-2031589-1.patch queued for re-testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

1: drupal-drupalkernal.php-2031589-1.patch queued for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed 6856f73 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.