Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Followup from #2015789-73: Remove language_css_alter() (RTL stylesheets) in favor of HTML 'dir' attribute, it is preferred to quote the attribute selector. This patch changes all instances of [dir=rtl] to [dir="rtl"]
Comment | File | Size | Author |
---|---|---|---|
#4 | quote-rtl-attribute-2030925-4.patch | 77.81 KB | echoz |
quote-rtl-attribute.patch | 78.63 KB | echoz | |
Comments
Comment #1
jessebeach CreditAttribution: jessebeach commentedLooks great. Good hustle echoz.
Comment #2
Wim LeersCore committers: see the reasoning for this at #2015789-73: Remove language_css_alter() (RTL stylesheets) in favor of HTML 'dir' attribute.
Comment #3
alexpottNeeds a reroll
Comment #4
echoz CreditAttribution: echoz commentedcommit all the things! :-D
Comment #5
penyaskitoLooks ok.
Comment #6
jessebeach CreditAttribution: jessebeach commentedLooks great, let's get this in before it becomes invalid. It touches too much code to continue to apply for too long.
Comment #7
jessebeach CreditAttribution: jessebeach commented#4: quote-rtl-attribute-2030925-4.patch queued for re-testing.
Comment #8
YesCT CreditAttribution: YesCT commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #9
alexpottCommitted b48f8fd and pushed to 8.x. Thanks!