Support from Acquia helps fund testing for Drupal Acquia logo

Comments

emma.maria’s picture

Status: Active » Needs work
FileSize
517.95 KB
606 bytes

I have tidied up the text by aligning everything with the first header. RTL styles have also been added. However a class needs to be applied to this page to override the default installer page styles.

mordonez’s picture

Status: Needs work » Needs review
FileSize
812 bytes

I think it's only necessary align the "ul" and decreasing the site-name space.

ckrina’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
469.56 KB

Last patch works fine.

ckrina’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
766 bytes
111.15 KB
117.42 KB

Sorry, reviewed on RTL and still some changes needed.
Attaching screenshots.

aspilicious’s picture

+++ b/core/themes/seven/install-page.cssundefined
@@ -59,12 +59,20 @@ body.install-page {
+  body.install-page #content ul{
+    padding: 15px;
+    margin: 0.25em 0 0.25em 0em;
+  }
+  [dir=rtl] body.install-page #content ul{
+    margin: 0.25em 0em 0.25em 0;
   }

0 or 0em sounds the same. Or isn't it? I don't think we need the rtl version than as it is the same. If not explain me what the difference is between 0 en 0em.

ckrina’s picture

rteijeiro’s picture

Status: Needs review » Needs work

[dir=rtl] must be [dir="rtl"] according to #2015789: Remove language_css_alter() (RTL stylesheets) in favor of HTML 'dir' attribute

I'm not sure about using #content. We should use less specific selectors and classes when possible.

emma.maria’s picture

Assigned: Unassigned » emma.maria
emma.maria’s picture

Assigned: emma.maria » Unassigned
Status: Needs work » Needs review
FileSize
2.12 KB

I have changed all of the [dir=rtl] to [dir="rtl"]. I have removed the #content from the ul selector as requested and also the body.install-page as it is not needed here.

rteijeiro’s picture

Status: Needs review » Reviewed & tested by the community

It seems good.

LewisNyman’s picture

+1 RTBC

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.