Problem/Motivation
The examples are have errors and used deprecated functions
Most of examples does not reflect NG changes.
Examples are highly dependent on comment module and will conflict with #731724: Convert comment settings into a field to make them work with CMI and non-node entities
Proposed resolution
Rewrite examples without comment module related parts
Comment | File | Size | Author |
---|---|---|---|
#31 | node-api-clean-up-2030191-31.patch | 2.62 KB | j2r |
#25 | node-api-clean-up-2030191-24.patch | 2.62 KB | j2r |
#24 | node-api-clean-up-2030191-23.patch | 4.09 KB | henk |
#19 | node-api-clean-up-2030191-19.patch | 3.97 KB | millerbennett |
#17 | patch_error.png | 24.66 KB | gippy |
Comments
Comment #1
andypostInitial changes
Comment #2
andypost#1: 2030191-nodeapi-1.patch queued for re-testing.
Comment #4
andypostComment #5
forbesgraham CreditAttribution: forbesgraham commentedThis patch updates all uses of the user_access function. This is only my third commit to core, so I hope I got it right! :)
Comment #6
forbesgraham CreditAttribution: forbesgraham commentedComment #8
tarekdj CreditAttribution: tarekdj commentedI think you have to delete the 3rd line from code above.
Comment #9
andypostFill namespace should be added to @param docblock
and use NodeInterface & AccountInterface in arguments
Comment #10
xjm(Merging "node system" and "node.module" components for 8.x; disregard.)
Comment #11
InternetDevels CreditAttribution: InternetDevels commentedComment #12
andypostGreat!
Comment #13
alexpottNeeds a reroll
Comment #14
IshaDakota CreditAttribution: IshaDakota commentedRe-rolled
Comment #15
andypostOther places should be update as well
Also docs should be cleaned for type-hint to
\Drupal\node\NodeInterface
so this needs some work to detect what hooks are passing.Currently file contains a mix of both interfaces
Comment #16
andypostNodeInterface part would be changed in #2067345: Change EntityInterface type hints to NodeInterface where appropriate
Comment #17
gippy CreditAttribution: gippy commentedPatch 15 no longer matches the current head.
Comment #18
gippy CreditAttribution: gippy commentedComment #19
millerbennett CreditAttribution: millerbennett commentedRe-rolled manually
Comment #20
andypost+1 rtbc
Comment #22
henk CreditAttribution: henk commentedPatch needs re-roll, tested on latest code Drupal 8.0.x.
Comment #24
henk CreditAttribution: henk commentedOk, patch is rerolled. Should be ok now.
Comment #25
j2r CreditAttribution: j2r commentedLast patch fail with this message
Adding a new patch with minor changes from last patch.
Comment #26
Manjit.SinghComment #27
RavindraSingh CreditAttribution: RavindraSingh as a volunteer and at Srijan | A Material+ Company commented@j2r, Patch seems fine to me, but it will be great if you can add interdiff also to show the different between #24 and #25
To know more https://www.drupal.org/documentation/git/interdiff
And do not forget to add you have re-rolled the patch. Also please make sure if the test for the node.api is having the same scenario/comments.
Comment #28
j2r CreditAttribution: j2r commented@RavindraSingh : I think interdiff is not possible as I am not able to apply the previous patch.
Comment #29
Manjit.Singhyup, interdiff is not necessary while we are rerolling a patch :)
Comment #30
googletorp CreditAttribution: googletorp as a volunteer commentedLooks good to me.
Comment #31
j2r CreditAttribution: j2r commentedSorry for adding one more file. Just missed a space in last 'langcode'.
@googletorp - Thanks for review and RTBC.
Comment #32
alexpottDocumentation changes are permitted during beta. Committed 150dc50 and pushed to 8.0.x. Thanks!