Configuring CKEditor's ACF broke CKEditor configuration -> filter setting syncing [#2028457]

So, #1936392: Configure CKEditor's "Advanced Content Filter" (ACF) to match Drupal's text filters settings broke #1894644: Unidirectional editor configuration -> filter settings syncing.

The reason is that the former sets allowedContent on all CKEditor instances, including the hidden CKEditor instance that the latter uses to perform its magic. Because ACF is configured for the hidden CKEditor instance, each button no longer comes with a set of ACF rules (because the former overrides them), and hence the feature is broken.

Result: when e.g. the "subscript" button is added to the "Basic HTML" text format, the <sub> tag is no longer being added. The trivial patch fixes that.

Comment	File	Size	Author
#1	2028457-1.patch	1.36 KB	Wim Leers
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 26 June 2013 at 10:20

Title:	Configuring CKEditor's ACF broke CKEditor configuration -> filter setting syncing.	» Configuring CKEditor's ACF broke CKEditor configuration -> filter setting syncing
Status:	Active	» Reviewed & tested by the community

File	Size
2028457-1.patch	1.36 KB

I'm not normally in favor of RTBC'ing directly, but: this is a simple patch, and I'm one of the very few people who know this, and the only one who knows it in-depth. So, rather than waiting a week to get to RTBC, I'd rather get this simple, critical bugfix committed now.

Comment #2

quicksketch

he/him

CreditAttribution: quicksketch commented 26 June 2013 at 21:27

Makes sense to me. I'm not sure I could be much clearer than Wim's original post but here's a stab:

- We collect the list of tags from individual plugins' "allowedContent" setting via a hidden CKEditor instance on the page.
- However if you set the *global* "allowedContent" variable on the editor, the plugin settings are ignored.
- So before initializing our hidden CKEditor instance, we need to remove the global "allowedContent" setting so the individual plugin settings come through, allowing us to pull in an accurate tag list.

So that's what this simple patch does, simply unsets the allowedContent variable before initializing the editor. RTBC +1.