Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There are two Php.php files inside Views module (argument validator/default) that must be moved under the php module.
- git move (see https://drupal.org/documentation/git/configure renames = copies) the file
- change namespace appropriately
- add the relevant use Drupal\views\Plugin\views\argument_validator\ArgumentValidatorPluginBase / argument_default\ArgumentDefaultPluginBase statements.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | move-diff.txt | 5.42 KB | dawehner |
| #3 | interdiff.txt | 3.05 KB | dawehner |
| #3 | vdc-2028041-2.patch | 5.63 KB | dawehner |
| #1 | php_arguments-2028041-1.patch | 12 KB | plopesc |
Comments
Comment #1
plopescHello
Attaching patch that moves PHP default argument and argument validator to PHP module.
Regards
Comment #2
chx CreditAttribution: chx commentedVery nice job, separating out the test like that.
With this patch, all evals are now inside the PHP module.
Comment #3
dawehnerIt is a perfect idea to move this functionality to the php module.
Here is also a move diff, as it is way easier to review, so no credit please.
Additional there are some fixes involved which seemed to be required to get this change in.
Comment #4
chx CreditAttribution: chx commentedOh sure, thanks for fixing it up. (Although I still object fixing Contains vs Definition piecemeal, it needs to be done in one go, but as long as it doesnt block a patch why not.)
Comment #5
alexpottCommitted a5c9398 and pushed to 8.x. Thanks!