[Change notice] Move views_theme_functions() to ViewExecutable method [#2027031]

Comment	File	Size	Author
#2	2027031-2.patch	10.78 KB	damiankloip

	vdc.remove-views_theme_functions.patch	10.39 KB	damiankloip

Comment #1

German

CreditAttribution: dawehner commented 24 June 2013 at 16:38

+++ b/core/modules/views/lib/Drupal/views/ViewExecutable.phpundefined
@@ -2111,4 +2112,36 @@ public function mergeDefaults() {
+   * Provide a full array of possible themes to try for a given hook.
...
+  public function buildThemeFunctions($hook) {

Do we also return something ^^

+++ b/core/modules/views/lib/Drupal/views/ViewExecutable.phpundefined
@@ -2111,4 +2112,36 @@ public function mergeDefaults() {
+   * @param string|null $display
+   *   The display being rendered, if applicable.

This parameter seems to removed.

+++ b/core/modules/views/tests/Drupal/views/Tests/BuildThemeFunctionsTest.phpundefined
@@ -0,0 +1,90 @@
+class BuildThemeFunctionsTest extends UnitTestCase {

Unit Test all the things, but can we just have a ViewExecutable test?

Log in or register to post comments

Comment #2

damiankloip CreditAttribution: damiankloip commented 24 June 2013 at 16:47

File	Size
2027031-2.patch	10.78 KB

Nice, thank you!

I have changed the test to be called ViewExecutableUnitTest, as unfortunately we already have ViewExecutableTest, and simpletest module loads all namespaces, so we get a conflict!

Log in or register to post comments

Comment #3

damiankloip CreditAttribution: damiankloip commented 24 June 2013 at 16:48

Sorry, forgot the interdiff....oh well! :) It's a smallish patch.

Log in or register to post comments

Comment #4

dawehner

German

CreditAttribution: dawehner commented 24 June 2013 at 23:31

Issue tags:

+PHPUnit

Wow, did we really managed to implement two patterns for the test files?

core/tests looks like this:

core/tests/Drupal/Tests/Core/FooTest

core/modules/{module} looks like this:

core/modules/{module}/Drupal/{module}/Tests/FooTest

I guess we should switch to the second one everywhere?

Log in or register to post comments

Comment #5

damiankloip CreditAttribution: damiankloip commented 25 June 2013 at 07:14

Issue tags:

-PHPUnit

Yeah, that's what I have been assuming. That we use the same dir structure in /tests/ as we do in /lib/. This is not an issue with this patch though?

Log in or register to post comments

Comment #6

dawehner

German

CreditAttribution: dawehner commented 25 June 2013 at 16:37

Status:

Needs review

» Reviewed & tested by the community

Let's get it in now.

Log in or register to post comments

Comment #7

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 28 June 2013 at 06:34

Status:

Reviewed & tested by the community

» Needs work

Committed fc9584d and pushed to 8.x. Thanks!

Log in or register to post comments

Comment #8

damiankloip CreditAttribution: damiankloip commented 28 June 2013 at 07:13

Status:

Needs work

» Fixed

Fixed? :)

Log in or register to post comments

Comment #9

12 July 2013 at 07:21

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #10

xjm

she/her

English

CreditAttribution: xjm commented 31 July 2013 at 22:54

Title:	Move views_theme_functions() to ViewExecutable method	» [Change notice] Move views_theme_functions() to ViewExecutable method
Project:	Drupal core	» Views (for Drupal 7)
Version:	8.x-dev	» 8.x-3.x-dev
Component:	views.module	» Code
Status:	Closed (fixed)	» Active
Issue tags:		+Needs change record