Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#11 | vdc-2020859-11.patch | 2.92 KB | tim.plunkett |
#7 | 2020859-human_name-to-label-6.patch | 2.82 KB | vijaycs85 |
#7 | 2020859-diff-1-6.txt | 2.38 KB | vijaycs85 |
#1 | 2020859-human_name-to-label-1.patch | 455 bytes | vijaycs85 |
Comments
Comment #1
vijaycs85Initial patch...
Currently it is failing few test cases in #1952394-45: Add configuration translation user interface module in core
Comment #2
vijaycs85Comment #3
vijaycs85Comment #4
dawehnerOh right I should have spotted that.
Comment #5
tim.plunkettDo we want to fix it in these as well?
Comment #6
YesCT CreditAttribution: YesCT commentedWe are still getting exceptions,
341 passes, 0 fails, 4 exceptions, and 118 debug messages,
in config_translation (with these applied:
#2020867: Update contact module URL in test cases.
#2020347: Temporary fix for config_translation_enter_context until language context becomes an option
#2020343: remove instance of locale_storage()
#2020859: Change the occurance of 'human_name' to 'label' in views configuration & schema
)
http://screencast.com/t/vizSwnFKL
Undefined index: source
http://screencast.com/t/s4Oh3E8lTbUb
I'm not sure if those are causing the exceptions through. Or totally unrelated.
Note, #1952394: Add configuration translation user interface module in core will add tests that rely on schema so provides some test coverage of schema.
Comment #7
vijaycs85Yes, Updated them all and title to reflect the patch changes... back to 'Needs review'.
Comment #8
YesCT CreditAttribution: YesCT commentedOh, I see. sorry, those were config changes just for human name still, nothing else.
Which probably answers my question that it's not related to the other exceptions.
---
with patch applied,
$ ag human_name core
core/modules/field_ui/lib/Drupal/field_ui/DisplayOverview.php
150: 'human_name' => array(
334: 'human_name' => array(
So no more human_name in views.
Changes look good to me.
Comment #9
dawehnerComment #10
webchickLooks simple enough, but no longer applies.
Comment #11
tim.plunkettWas just a new directory added.
Comment #13
tim.plunkett#11: vdc-2020859-11.patch queued for re-testing.
Comment #14
YesCT CreditAttribution: YesCT commentedComment #15
alexpottCan confirm there are no traces of human_name in views, views_ui or any views YAML...
Committed 5356a24 and pushed to 8.x. Thanks!