* Modules that make any changes to variables like 'name' or 'extra' must insure

Should be "ensure".

CommentFileSizeAuthor
#2 docblock-fix-2020403-2.patch608 bytesharry99
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

harry99’s picture

harry99 CreditAttribution: harry99 commented
Assigned: Unassigned » harry99
harry99’s picture

harry99 CreditAttribution: harry99 commented
Status: Active » Needs review
FileSize
docblock-fix-2020403-2.patch608 bytes
harry99’s picture

harry99 CreditAttribution: harry99 commented

I am excited about my first Drupal-8 core contribution.

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, docblock-fix-2020403-2.patch, failed testing.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs work » Needs review

#2: docblock-fix-2020403-2.patch queued for re-testing.

dejahvuuu’s picture

dejahvuuu CreditAttribution: dejahvuuu commented
Issue tags: +Novice

#2: docblock-fix-2020403-2.patch queued for re-testing.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs review » Reviewed & tested by the community

looks good to me

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Yes, and I hear those modules' premiums are through the roof! :)

Good catch! Committed and pushed to 8.x. Thanks!

kgoel’s picture

kgoel CreditAttribution: kgoel commented
Status: Fixed » Closed (fixed)