Automatically create cache tables for entities that want to support entitycache.module

Convince @fago that we should do this

Are you kidding man? If he is a maintainer or co-maintainer and has time then he should work on solving this point, we do not have to convince him because if this feature is not repaired basically this module is unuseful and can be deprecated. :S

It mas have automatic detection of required entities for cache because every site has different entities and we cannot "play rulette" that maybe breaks the page maybe not.

And of course, everyone interest shoudl help to achieve this goal!

Sorry for contundence, I'm :) anyway and hope you too.

Ok, had a look at this together with dasjo. https://drupal.org/node/1336924#comment-7415234 is a good starting point, however let's do:

+++ b/entity.module
@@ -843,6 +843,77 @@ function _entity_defaults_rebuild($entity_type) {
+          // The following two conditions duplicate entity_crud_get_info(), but

Let's just use the helper + rely on the info 'module' key to match any of the installed modules. Yes we require devs to implement our own API ;-) Also document that entity cache support requires the module key to be specified at our entity_crud_hook_entity_info() 'entity cache' docs.

- hook_entity_info_alter() should be extended to disable "field-cache" automatically when entity cache is enabled and the module there.

- We should add all tables only when the module is there, and drop them if entitycache is uninstalled. Maybe best keep the install/uninstall logic in the .install file and call the helper from the hooks only to avoid cluttering the .module file further.

will post a patch soon

here's what i tested using the while module:

tables are created after entitycache install
tables are created after while install
tables are deleted after entitycache uninstall
tables are deleted after while while uninstall

Patch looks good and seems to work fine. Here a few minor remarks:

1. +++ b/entity.install
   @@ -26,3 +26,101 @@ function entity_update_7001() {
   + * Remove entity cache tables for supporting entity types of uninstalled modules.
   

   Summary is 1 char too long.

2. +++ b/entity.install
   @@ -26,3 +26,101 @@ function entity_update_7001() {
   + *   (optional) An array of uninstalled modules.
   + *   If not specified, try to remove cache tables for all modules.
   

   To early line break.

3. +++ b/entity.install
   @@ -26,3 +26,101 @@ function entity_update_7001() {
   +  foreach($modules as $module) {
   

   Missing space after foreach.

Figured we miss hook_flush_caches() impl and should create tables on hook_enable().

Also addressed above remarks.

Patch seems to work fine now - so this should be good to go. Further testers would be welcome!

Figured this uses required_once with a relative path - which it shouldn't as it depends on the configured include path. Instead it should use module_load_install('entity');

implemented suggested changes from #9

Thanks!

Awesome, thanks for all the great work everyone! :)

So, was this committed?

This seems to work fine, thus - committed.