Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Task to convert the json unit tests in the system module to use phpunit. Also will require deprecating drupal_json_encode/decode, and making a json component.
Comment | File | Size | Author |
---|---|---|---|
#12 | drupal-2016299-11.patch | 10.56 KB | dawehner |
#10 | drupal-2016299-10.patch | 11.31 KB | dawehner |
#7 | interdiff.txt | 7.09 KB | dawehner |
#7 | drupal-2016299-7.patch | 10.56 KB | dawehner |
#1 | system-json-2016299-01.patch | 6.68 KB | jhedstrom |
Comments
Comment #1
jhedstromPatch moves logic from
drupal_json_encode/decode()
to a utility component, and moves the tests to phpunit.Comment #3
Berdir#1: system-json-2016299-01.patch queued for re-testing.
Comment #4
ParisLiakos CreditAttribution: ParisLiakos commentednot sure if its worthy to convert those, since they ll probably die in favor of JsonResponse
Comment #5
jhedstromI'd still like to see them converted and then removed, rather than left in place should the JsonResponse work not happen.
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedSure, fine by me!
needs a newline in between
@param docs needed
Contains \Drupal\....
About the test: Maybe you could break it up to methods using dataProviders so we make it a bit more readable than now?
Comment #7
dawehnerI am not convinced that data providers would improve the readability, but splitting it up would certainly help.
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedbreaking it up that way works too:)
thanks!
Comment #9
alexpottNeeds a reroll
Comment #10
dawehnerJust another rerole.
Comment #11
ParisLiakos CreditAttribution: ParisLiakos commentedirrelevant hunk?
Comment #12
dawehnerGood catch!
Comment #13
ParisLiakos CreditAttribution: ParisLiakos commentedawesome thanks!
Comment #15
ParisLiakos CreditAttribution: ParisLiakos commented#12: drupal-2016299-11.patch queued for re-testing.
Comment #16
ParisLiakos CreditAttribution: ParisLiakos commentedback to rtbc
Comment #17
catchCommitted/pushed to 8.x, thanks!
Comment #19
jhedstrom