Expand NodeInterface to provide getters and setters

+++ b/core/modules/node/lib/Drupal/node/NodeInterface.phpundefined
@@ -14,4 +14,59 @@
+  /**
+   * The node comment status indicator.
+   *
+   * COMMENT_NODE_HIDDEN => no comments
+   * COMMENT_NODE_CLOSED => comments are read-only
+   * COMMENT_NODE_OPEN => open (read/write)
+   *
+   * @var int
+   */
+  public function getComment();

Maybe leave this out because I really hope this will become a configurable field.

+++ b/core/modules/node/lib/Drupal/node/NodeInterface.phpundefined
@@ -14,4 +14,59 @@
+  public function getUid();

For FileInterface, we chose getOwner() that returns the loaded user entity. How many use cases do we have that just want the uid and loading the user would be an overhead? Then maye have getOwner() (author?) and getOwnerId()?

+++ b/core/modules/node/lib/Drupal/node/NodeInterface.phpundefined
@@ -14,4 +14,59 @@
+  public function isPublished();

In FileInterface, I also added methods to change the status, could be publish() here.

Re-adding tags.

This is what I wanted to do for #1939994: Complete conversion of nodes to the new Entity Field API because it means we can convert all these so that it does no longer matter if we're working with an BC Decorator or not. Then we can convert to methods and only have to deal with the configurable fields (of which there's still going to be a ton, but..) when finally removing it.

Continuing a bit with this, added getAuthor() and getAuthorId() instead of getUid(), getCreatedTime() and getChangedTime(), removed the fake public properties, fixed some bugs in the conversions.

Also had some merge conflicts, so no useful interdiff.

That should fix (most?) of those errors, also removed getComment as suggested above, we can still add it back.

Re-roll.

Merge resulted in two getBCEntity() methods.

Weeeeird.

Can we move the getAuthor() and getAuthorID() methods to an EntityAuthorInterface? Then Comment could implement it as well as contrib entities.

I'd be happy to do it in a followup.

I'm not sure about splitting interfaces up too much, I think it makes it harder to understand what methods are available when looking at documentation (IDE's don't have a problem with it except you don't have the node specific methods bold anymore).

Let's also add setter methods and then get this in and continue to convert to the interface in #1939994: Complete conversion of nodes to the new Entity Field API.

Ok, added some setter methods, not sure about some names. publish/unpublish works, stick/unstick and promote/unpromote not as much. Should we go for setSticky(TRUE/FALSE) there?

#18: node-interface-methods-2015123-18.patch queued for re-testing.

+++ b/core/modules/node/lib/Drupal/node/Plugin/Core/Entity/Node.php
@@ -310,5 +141,116 @@ public static function preDelete(EntityStorageControllerInterface $storage_contr
+    $this->set('promoted', NODE_PROMOTED);

Possible scope creep: NODE_PROMOTED should really be NodeInterface::PROMOTED. Same for the other constants here.

(Feel free to ignore for scope reasons, but it should be a follow up if possible.)

+++ b/core/modules/node/lib/Drupal/node/Plugin/Core/Entity/Node.php
@@ -310,5 +141,116 @@ public static function preDelete(EntityStorageControllerInterface $storage_contr
+  /**
+   * {@inheritdoc}
+   */
+  public function stick() {
+    $this->set('sticky', NODE_STICKY);
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public function unstick() {
+    $this->set('sticky', NODE_NOT_STICKY);
+  }

setSticky(TRUE/FALSE) definitely works better for me. I'd be fine with setPublished(TRUE/FALSE) as well if it makes sense for consistency.

I'd like to postpone the constant changes. Because we use those methods as much as possible, most usages of them should go away, except probably queries. There might also be a discussion whether they should be on NodeInterface or Node.

Changed to setSticky(), setPromoted() and setPublished(), like the consistency argument.

+++ b/core/modules/node/lib/Drupal/node/NodeBCDecorator.php
@@ -13,4 +13,96 @@
+    $this->decorated->setAuthrorId($uid);

Typo: authRor

Thanks, fixed that and also converted a few additional calls.

Hm, BC fun. Let's see if this works better.

Added special handling for uid 0. Maybe the entityreference field should be improved instead. It doesn't seem to try to load the uid 0.

I did a manual review and apart from a few overly verbose @param and @return descriptions, the only things I found were three properties that have been removed, but do not seem to get equivalent methods in return, or have them already.

+++ b/core/modules/node/lib/Drupal/node/Plugin/Core/Entity/Node.php
@@ -60,175 +60,6 @@
-   * The node translation set ID.
-   *
-   * Translations sets are based on the ID of the node containing the source
-   * text for the translation set.
-   *
-   * @var \Drupal\Core\Entity\Field\FieldInterface
-   */

There is no equivalent.

+++ b/core/modules/node/lib/Drupal/node/Plugin/Core/Entity/Node.php
@@ -60,175 +60,6 @@
-   * The node revision creation timestamp.
-   *
-   * @var \Drupal\Core\Entity\Field\FieldInterface
-   */
-  public $revision_timestamp;

There is no equivalent for this.

+++ b/core/modules/node/lib/Drupal/node/Plugin/Core/Entity/Node.php
@@ -60,175 +60,6 @@
-  /**
-   * The node revision author's user ID.
-   *
-   * @var \Drupal\Core\Entity\Field\FieldInterface
-   */
-  public $revision_uid;

There is no equivalent for this.

Added methods for the revision stuff, leaving translation set ID out for now, that does not belong in here IMHO, translation.module stuff.

Also made the setters support fluent calls.

Fixing stupid typos. Making lots of them today.

#33: node-interface-methods-2015123-33.patch queued for re-testing.

#33: node-interface-methods-2015123-33.patch queued for re-testing.

Needs a reroll

curl https://drupal.org/files/node-interface-methods-2015123-33.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 35784  100 35784    0     0  12333      0  0:00:02  0:00:02 --:--:-- 13317
error: patch failed: core/modules/node/node.module:375
error: core/modules/node/node.module: patch does not apply

Re-rolled.

Green, back to RTBC.

Committed 083ee68 and pushed to 8.x. Thanks!

Added this issue to https://drupal.org/node/1806650, which already describes that interfaces have been added and links to the Node interface.