* notice: Undefined index: categories in ...\modules\aggregator\aggregator.pages.inc on line 145.
* warning: Invalid argument supplied for foreach() in ...\modules\aggregator\aggregator.pages.inc on line 145.

repro steps:
1. clean drupal cvs install
2. admin/build/modules enable Aggregator
2. admin/content/aggregator/add/feed (title: drupal, url: http://drupal.org/node/feed)
3. aggregator/sources/1/categorize click: Save categories

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

blackdog’s picture

This looks like a duplicate, can you try the patch in http://drupal.org/node/198609.

Pasqualle’s picture

tested the patch in #198609 now, but it does not solve this issue.

blackdog’s picture

Status: Active » Needs review
FileSize
1.21 KB

Sorry, my bad.

I've attached a patch for this issue.

Pasqualle’s picture

Status: Needs review » Reviewed & tested by the community

tested, works

please commit after #198609 if possible, then no more rerolls needed.

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Needs work

Technically, we are looking for an !empty() right? Not an isset(). Seems like the selector could be a checkbox list or a select box, so we get an array in all cases, that should not be checked for, the FAPI checks for the values there anyway. Also the if() should have a space after the keyword.

blackdog’s picture

Status: Needs work » Needs review
FileSize
1.27 KB

Updated patch checks !empty instead, with spacing.

Pasqualle’s picture

Status: Needs review » Reviewed & tested by the community

retested

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.