Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
+ // Set the request in the container to the new created Request above
+ // so it is available to the rest of the installation process.
+ $container
+ ->set('request', $request);
Should be enough, there's no point in rendering an array into #markup to be passed back to drupal_render() a second time as drupal_render() is already recursive.
Comments
Comment #1
Zdorovega CreditAttribution: Zdorovega commentedComment #2
thedavidmeister CreditAttribution: thedavidmeister commentedJust wondering why we need this bit?
This should be #hide right?
and this #header, #rows, #attributes?
Comment #3
Zdorovega CreditAttribution: Zdorovega commentedthank you, the above issues have been fixed.
Comment #4
star-szrSending to testbot for now. Thanks @redfoxxx.ua!
Comment #6
Samvel CreditAttribution: Samvel commented@redfoxxx.ua
instead this one:
need:
Comment #7
InternetDevels CreditAttribution: InternetDevels commentedWe are working today with this issue during Code Sprint UA.
Comment #8
InternetDevels CreditAttribution: InternetDevels commentedPatch attached.
Comment #9
InternetDevels CreditAttribution: InternetDevels commentedComment #10
podarok#8 nice work
Comment #11
catch#8: replace_theme_function_with_drupal_render_in_user_module-2009690-8.patch queued for re-testing.
Comment #13
JeroenTReplaced theme() with drupal_render().
Comment #14
thedavidmeister CreditAttribution: thedavidmeister commented+ '#theme' => 'pager',
Trailing whitespace issue here.
This looks weird to me.
$form['pager'] = array('#theme' => 'pager'),
Should be enough, there's no point in rendering an array into #markup to be passed back to drupal_render() a second time as drupal_render() is already recursive.
Closing parenthesis is indented too far here.
Comment #15
JeroenTOk, thanks!
Made changes as suggested by thedavidmeister
Comment #16
JeroenTI forgot to remove:
This is the right patch.
Comment #17
thedavidmeister CreditAttribution: thedavidmeister commentedThis should either be one line or have a trailing comma after 'permissions'
Comment #18
hussainwebAdded the trailing comma and removed some extra whitespace.
Comment #19
scor CreditAttribution: scor commentedlooks good. all comments have been addressed.
Comment #20
alexpottCommitted 9dd08c0 and pushed to 8.x. Thanks!
Comment #21
alexpott