It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().
The last submitted patch, 2009666-replace_theme_with_drupal_render_in_search-1.patch, failed testing.
$output['suffix']['#markup'] = '</ol>' . drupal_render(array('#theme' => 'pager'));
You can't do this kind of thing with drupal_render() or you'll get fatal errors.
You *must* declare your array and pass it to drupal_render() in two steps as drupal_render() will attempt to modify it by reference.
Eg:
$pager = array('#theme' => 'pager'); drupal_render($pager);
The last submitted patch, 2009666-replace_theme_with_drupal_render_in_search-2.patch, failed testing.
Replaced theme with drupal_render.
this looks good to me
Committed 33b0337 and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
Comments
Comment #1
aaronott CreditAttribution: aaronott commentedComment #3
thedavidmeister CreditAttribution: thedavidmeister commented$output['suffix']['#markup'] = '</ol>' . drupal_render(array('#theme' => 'pager'));
You can't do this kind of thing with drupal_render() or you'll get fatal errors.
You *must* declare your array and pass it to drupal_render() in two steps as drupal_render() will attempt to modify it by reference.
Eg:
Comment #4
jlandfried CreditAttribution: jlandfried commentedComment #6
JeroenTReplaced theme with drupal_render.
Comment #7
thedavidmeister CreditAttribution: thedavidmeister commentedthis looks good to me
Comment #8
alexpottCommitted 33b0337 and pushed to 8.x. Thanks!