Switch CommentPreviewTest from standard profile to testing [#2009632]

Comment	File	Size	Author
#7	comment_preview_testing-2009632-7.patch	1.65 KB	giammi

#7	comment_preview_testing-2009632-7.interdiff.txt	481 bytes	giammi
#2	comment_preview_testing-2009632-1.patch	1.71 KB	dawehner

#1	comment-2009632-1.patch	1.6 KB	tim.plunkett

Comment #1

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 1 June 2013 at 09:08

Status:

Active

» Needs review

File	Size
comment-2009632-1.patch	1.6 KB

This goes from 3.5 minutes to 40 seconds for me.

Log in or register to post comments

Comment #2

dawehner

German

CreditAttribution: dawehner commented 1 June 2013 at 09:10

File	Size
comment_preview_testing-2009632-1.patch	1.71 KB

Let's do it.

Log in or register to post comments

Comment #3

dawehner

German

CreditAttribution: dawehner commented 29 June 2013 at 16:14

Issue tags:

-Test suite performance

#2: comment_preview_testing-2009632-1.patch queued for re-testing.

Log in or register to post comments

Comment #4

Berdir

German

Switzerland

CreditAttribution: Berdir commented 5 August 2013 at 16:15

Issue tags:

+Test suite performance

#2: comment_preview_testing-2009632-1.patch queued for re-testing.

Log in or register to post comments

Comment #5

Berdir

German

Switzerland

CreditAttribution: Berdir commented 5 August 2013 at 19:24

Status:

Needs review

» Needs work

+++ b/core/modules/comment/lib/Drupal/comment/Tests/CommentPreviewTest.phpundefined
@@ -32,6 +32,35 @@ public static function getInfo() {
   /**
+   * {@inheritdoc}
+   */
+  function setUp() {

setUp() methods don't have docblocks according to our current standards.

Stupid nitpick, I know, but I'm happy to RTBC after that :)